Skip to content

Add download URL for executable files #28260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Add download URL for executable files #28260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356c4fe
Add download URL for executable files
Gusted Nov 28, 2023
002bd36
Merge branch 'main' into wip-gitea-forgejo-download-url-exec
wxiaoguang Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/repository/files/content.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ func GetContents(ctx context.Context, repo *repo_model.Repository, treePath, ref
}
}
// Handle links
if entry.IsRegular() || entry.IsLink() {
if entry.IsRegular() || entry.IsLink() || entry.IsExecutable() {
Copy link
Member

@delvh delvh Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are directories stored in git?
As 755?
If yes, then is it reported as executable too?

Copy link
Contributor

@wxiaoguang wxiaoguang Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no response from author, I would like to try to answer it .... I think it is right, because the entry mode is determined by separate constants (not by bit masks):

image

downloadURL, err := url.Parse(repo.HTMLURL() + "/raw/" + url.PathEscape(string(refType)) + "/" + util.PathEscapeSegments(ref) + "/" + util.PathEscapeSegments(treePath))
if err != nil {
return nil, err
Expand Down