Skip to content

Fix rerun button of Actions #22798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2023
Merged

Fix rerun button of Actions #22798

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa6c3c1
fix: refresh page after rerun
wolfogre Feb 7, 2023
0fd90b4
Merge branch 'main' into bugfix/actions_rerun
wolfogre Feb 7, 2023
0d99de3
fix: rename to fetchPost and remove callback
wolfogre Feb 7, 2023
a2748b8
chore: code can talk
wolfogre Feb 7, 2023
104a4f3
chore: comments for button
wolfogre Feb 7, 2023
64bc55a
Merge branch 'main' into bugfix/actions_rerun
wolfogre Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions web_src/js/components/RepoActionView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<SvgIcon name="octicon-meter" class="ui text yellow" class-name="job-status-rotate" v-else-if="job.status === 'running'"/>
<SvgIcon name="octicon-x-circle-fill" class="red" v-else/>
{{ job.name }}
<button class="job-brief-rerun" @click="rerunJob(index)" v-if="job.canRerun">
<button class="job-brief-rerun" @click.prevent="rerunJob(index)" v-if="job.canRerun">
<SvgIcon name="octicon-sync" class="ui text black"/>
</button>
</a>
Expand Down Expand Up @@ -163,7 +163,13 @@ const sfc = {
},
// rerun a job
rerunJob(idx) {
this.fetch(`${this.run.link}/jobs/${idx}/rerun`);
const jobLink = `${this.run.link}/jobs/${idx}`;
this.fetch(`${jobLink}/rerun`, null, () => {
// The button to rerun job is under "a" tag, so the browser will refresh the page and cancel fetching "rerun".
// However, it should refresh the page because the logs have been reset, or it's another job which has been clicked.
// So we prevent the default behavior and refresh the page after the fetching is done.
window.location.href = jobLink;
});
},
// cancel a run
cancelRun() {
Expand Down Expand Up @@ -245,14 +251,18 @@ const sfc = {
}
},

fetch(url, body) {
fetch(url, body, callback) {
return fetch(url, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
'X-Csrf-Token': csrfToken,
},
body,
}).finally(() => {
if (callback) {
callback();
}
});
},
},
Expand Down