Skip to content

Make gitea work using cmd.exe again #22073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 14, 2022
Merged

Make gitea work using cmd.exe again #22073

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa1a3ae
Make gitea work using cmd.exe again
zeripath Dec 8, 2022
88a5270
fix to work on go1.18
zeripath Dec 13, 2022
6793726
Merge branch 'main' into fix-22063-default-app-path
lunny Dec 13, 2022
b4bfc82
Merge branch 'main' into fix-22063-default-app-path
techknowlogick Dec 13, 2022
1bc5c10
Merge branch 'main' into fix-22063-default-app-path
techknowlogick Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/setting/setting.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,13 @@ func getAppPath() (string, error) {
appPath, err = exec.LookPath(os.Args[0])
}

if err != nil {
// FIXME: Once we switch to go 1.19 use !errors.Is(err, exec.ErrDot)
if !strings.Contains(err.Error(), "cannot run executable found relative to current directory") {
return "", err
}
appPath, err = filepath.Abs(os.Args[0])
}
if err != nil {
return "", err
}
Expand Down