Skip to content

Adjust clone timeout error to suggest increasing timeout #21769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Adjust clone timeout error to suggest increasing timeout #21769

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
214da05
Adjust clone timeout error to suggest increasing timeout
zeripath Nov 10, 2022
a4b2fe0
Merge branch 'main' into ref-20680-adjust-clone-logging-when-timeout
lunny Nov 11, 2022
5d7eb97
Merge branch 'main' into ref-20680-adjust-clone-logging-when-timeout
6543 Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/repository/repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package repository

import (
"context"
"errors"
"fmt"
"io"
"net/http"
Expand Down Expand Up @@ -79,6 +80,9 @@ func MigrateRepositoryGitData(ctx context.Context, u *user_model.User,
Timeout: migrateTimeout,
SkipTLSVerify: setting.Migrations.SkipTLSVerify,
}); err != nil {
if errors.Is(err, context.DeadlineExceeded) {
return repo, fmt.Errorf("Clone timed out. Consider increasing [git.timeout] MIGRATE in app.ini. Underlying Error: %w", err)
}
return repo, fmt.Errorf("Clone: %w", err)
}

Expand Down