Should also support upper-case README files #20581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Aug 1, 2022
GiteaBot
added
the
lgtm/need 1
lunny
added
type/bug
skip-changelog
wxiaoguang
approved these changes
Aug 1, 2022
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
Although I think it's not necessary to make the ext name case-insensitive, it's not bad to do so.
GiteaBot
added
lgtm/done
Member
Author
For the record, it's for something like ".zh_CN.md" so "README.zh_cn.md" will also be okay. Also maybe some DOS fans will also find it be useful so "README.MD" can be accepted :) It's not required in the current code base through since |
Member
|
make L-G-T-M work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 2, 2022
* giteaofficial/main: Rework mailer settings (go-gitea#18982) Add default value for clone URLs (go-gitea#20600) [skip ci] Updated translations via Crowdin docs: zh-cn translations for fail2ban setup (go-gitea#20588) Should also support upper-case README files (go-gitea#20581) Fix typos in backup documentation (go-gitea#20567)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the issue introduced in #20508 (79741dd), also added some case in existing test that cover this issue.
IsReadmeFileExtensiononly match the lower-casereadmefile, and also require the extensions use the same caption case as the provided ones, soREADME.mdandreadme.MDwill no longer be supported. After this patch, it will be once again become supported.