Avoid running go vet twice #18059
Merged
Avoid running go vet twice #18059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- go vet is already ran by golangci-lint as linter(and must faster). `make vet` will only run gitea-vet(which is as fast as revivie). - Thanks for @zeripath for pointing out slow linting.
zeripath
approved these changes
Dec 21, 2021
GiteaBot
added
the
lgtm/need 1
jolheiser
approved these changes
Dec 21, 2021
GiteaBot
added
lgtm/done
techknowlogick
approved these changes
Dec 21, 2021
techknowlogick
added
the
skip-changelog
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make vetwill only run gitea-vet(which is as fast as revivie).