Skip to content

Fix reactions on code comments #13390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2020
Merged

Fix reactions on code comments #13390

merged 2 commits into from
Nov 2, 2020

Conversation

@CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Nov 1, 2020

Fixes #13387

There were two issues:

  1. context was incorrectly passed into template
  2. reactions were not loaded for code comments

@lafriks lafriks modified the milestones: 1.13.0, 1.14.0 Nov 1, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2020
@lafriks
Copy link
Member

lafriks commented Nov 2, 2020

pelase send backport

@lafriks lafriks merged commit 06268dc into go-gitea:master Nov 2, 2020
@CirnoT CirnoT deleted the react-codecomment branch November 2, 2020 13:22
CirnoT added a commit to CirnoT/gitea that referenced this pull request Nov 2, 2020
@CirnoT
Fix reactions on code comments (go-gitea#13390)
e193f10 
Co-authored-by: Lunny Xiao <[email protected]>

(cherry picked from commit 06268dc)
lunny pushed a commit that referenced this pull request Nov 2, 2020
@CirnoT
Fix reactions on code comments (#13390) (#13401)
350c10f 
Co-authored-by: Lunny Xiao <[email protected]>

(cherry picked from commit 06268dc)
@lunny lunny added the backport/done All backports for this PR have been created label Nov 2, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@a1012112796 a1012112796 a1012112796 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

Unable to react on inline comments

6 participants

@CirnoT @lafriks @silverwind @a1012112796 @lunny @GiteaBot