Edit comment bug: can not save empty comment

[yp05327]

Description

1. can not save empty comment
   I think we need to check oldContent == comment.Content instead of len(comment.Content) == 0
   and return an empty json, then check data.content === undefined in js.
   

---

(the second one has been fixed)

2. edit comment regression

Caused by #29843
after the edition you will see this strange code:

If I revert the changes from #29843, it works
Have no idea how to fix this, as lint not allow using append.
maybe other changes in #29843 will also have this issue?
the appended data will be text not DOM element.

Gitea Version

latest

[yardenshoham]

• Fix: Abnormal strings appear when comments are saved after editing #29991 fixes the bug caused by Forbid HTML injection using jQuery #29843

[yardenshoham]

@wxiaoguang should we remove issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP now?

[wxiaoguang]

Oh yes, I just added it for remembering (to make sure it could be fixed in 1.22 milestone). It gets fixed pretty fast. Thank you.

---

And I edited the description to make it clear. 😁

[wxiaoguang]

For the first one: "can not save empty comment"

I think it could be considered as not a bug. I think it doesn't make sense to update to an empty content. Especially in some templates, it checks if .Content to use different layouts.

[yp05327]

For the first one, actually what I want to say is that the JSON returns empty content, and we have no empty check in JS, so this will cause a bug here. Also for the dropzone-attachments. Although the second one was fixed, but you will still see it, if you want to clear the comment.

In the latest version (1.22.0+dev-1175-g428e05662f)