gitea change spaces (%20) to signal +

[heliomcp]

• Gitea version (or commit ref): Latest version in try.gitea.io
• Git version:
• Operating system:
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
    Navigate in this url https://try.gitea.io/heliomcp/testes/src/branch/master/Teste%20A between the 2 files using markdown links.
  • No
  • Not relevant
• Log gist:

Description

Every time I have a directory name with a space and try to use markdown links, gitea change the space to '+' instead of '%20' and it gives 404.
...

Screenshots

Original Markdown

Render OK

BAD Link (directory with space)

[heliomcp]

I have included screenshots to exemplify the error.

[mrsdizzie]

This is because of:

gitea/modules/markup/markdown/markdown.go

Lines 33 to 38 in a97fe76

	func NewGiteaParseContext(urlPrefix string, isWiki bool) parser.Context {
	pc := parser.NewContext(parser.WithIDs(newPrefixedIDs()))
	pc.Set(urlPrefixKey, urlPrefix)
	pc.Set(isWikiKey, isWiki)
	return pc
	}

urlPrefix in this case will be /heliomcp/testes/src/branch/master/Teste+A

Which will be used here to generate the link:

gitea/modules/markup/markdown/goldmark.go

Lines 69 to 87 in a97fe76

	case *ast.Link:
	// Links need their href to munged to be a real value
	link := v.Destination
	if len(link) > 0 && !markup.IsLink(link) &&
	link[0] != '#' && !bytes.HasPrefix(link, byteMailto) {
	// special case: this is not a link, a hash link or a mailto:, so it's a
	// relative URL
	lnk := string(link)
	if pc.Get(isWikiKey).(bool) {
	lnk = giteautil.URLJoin("wiki", lnk)
	}
	link = []byte(giteautil.URLJoin(pc.Get(urlPrefixKey).(string), lnk))
	}
	if len(link) > 0 && link[0] == '#' {
	link = []byte("#user-content-" + string(link)[1:])
	}
	v.Destination = link
	}
	return ast.WalkContinue, nil

Then the link itself fails because it looks for Teste+A here:

gitea/routers/repo/view.go

Lines 503 to 508 in a97fe76

	// Get current entry user currently looking at.
	entry, err := ctx.Repo.Commit.GetTreeEntryByPath(ctx.Repo.TreePath)
	if err != nil {
	ctx.NotFoundOrServerError("Repo.Commit.GetTreeEntryByPath", git.IsErrNotExist, err)
	return
	}

and fails

2020/02/14 19:07:38 routers/repo/view.go:506:renderCode() [E] Repo.Commit.GetTreeEntryByPath: object does not exist [id: , rel_path: Teste+A]
	/Users/mrsdizzie/.go/src/code.gitea.io/gitea/routers/repo/view.go:506 (0x535b3e8)
		renderCode: ctx.NotFoundOrServerError("Repo.Commit.GetTreeEntryByPath", git.IsErrNotExist, err)
	/Users/mrsdizzie/.go/src/code.gitea.io/gitea/routers/repo/view.go:441 (0x535a021)
		Home: renderCode(ctx)

So while a + might be considered valid for the URL it is then being used literally when trying to get the tree entry and fails because there is no path of Teste+A

And source of blank space being converted into a + for ctx.urlPrefix is:

gitea/modules/markup/markup.go

Lines 83 to 92 in a97fe76

	func render(parser Parser, rawBytes []byte, urlPrefix string, metas map[string]string, isWiki bool) []byte {
	urlPrefix = strings.Replace(urlPrefix, " ", "+", -1)
	result := parser.Render(rawBytes, urlPrefix, metas, isWiki)
	// TODO: one day the error should be returned.
	result, err := PostProcess(result, urlPrefix, metas, isWiki)
	if err != nil {
	log.Error("PostProcess: %v", err)
	}
	return SanitizeBytes(result)
	}

So I assume this never worked and isn't related to switching to goldmark. @zeripath -- should we just be be replacing a blank space with %20 when rendering markdown here instead of a +? Just tagging you since you did a lot with the markdown code recently.

I see we do this strings.Replace(var, " ", "+", -1) a couple of places but seems like it should be %20 if those strings are also going to be used for looking at files on disk

[zeripath]

That should work.

[mrsdizzie]

OK I'll think on it a bit more and do a PR to fix this then