-
Notifications
You must be signed in to change notification settings - Fork 11
feat: support Gnosis primitives (full history 1 of 2) #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prerelease/v1.8.2
Are you sure you want to change the base?
Conversation
…pdate GnosisEngineValidatorBuilder comment
…te related constants and logic. Adjusted chain value parser to recognize "devnet" as an alias for "fusaka-devnet-5".
- Introduced new dependencies: `bincode`, `gnosis-primitives`, `prettyplease`, `serde_combinators`, and `test-fuzz`. - Updated `Cargo.toml` to include `gnosis-primitives` as a git dependency. - Refactored various source files to utilize `GnosisHeader` and `GnosisBlock` types, enhancing compatibility with Gnosis-specific logic.
…al and update genesis header initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight forward change! thanks for the PR notes
src/primitives/block.rs
Outdated
| pub type BlockBody = alloy_consensus::BlockBody<TransactionSigned, GnosisHeader>; | ||
|
|
||
| /// Trait to convert a consensus block into a `GnosisBlock` | ||
| pub trait IntoBlock { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name the trait IntoGnosisBlock and the function into_gnosis_block. Is this used widely? Why not just have a helper somewhere instead of the trait?
src/primitives/block.rs
Outdated
| pub type TransactionSigned = alloy_consensus::EthereumTxEnvelope<TxEip4844>; | ||
|
|
||
| pub type GnosisHeader = alloy_consensus::Header; | ||
| // pub type GnosisHeader = alloy_consensus::Header; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge as is, the comments are minor
This introduces support for GnosisHeader instead of alloy_consensus::Header. Major change is replacing Header with GnosisHeader.
Additionally, it includes some conversions between
Block<->GnosisBlockto be used for interfacing with reth's payload building.This PR also gets rid of the hardcoded
genesis_hashbecause now it can properly form the genesis header (which is in aura format).