Skip to content

Conversation

@debjit-bw
Copy link
Member

@debjit-bw debjit-bw commented Sep 28, 2025

This introduces support for GnosisHeader instead of alloy_consensus::Header. Major change is replacing Header with GnosisHeader.

Additionally, it includes some conversions between Block <-> GnosisBlock to be used for interfacing with reth's payload building.

This PR also gets rid of the hardcoded genesis_hash because now it can properly form the genesis header (which is in aura format).

…te related constants and logic. Adjusted chain value parser to recognize "devnet" as an alias for "fusaka-devnet-5".
- Introduced new dependencies: `bincode`, `gnosis-primitives`, `prettyplease`, `serde_combinators`, and `test-fuzz`.
- Updated `Cargo.toml` to include `gnosis-primitives` as a git dependency.
- Refactored various source files to utilize `GnosisHeader` and `GnosisBlock` types, enhancing compatibility with Gnosis-specific logic.
@debjit-bw debjit-bw changed the title Add custom primitives feat: custom primitives for aura headers Sep 29, 2025
Base automatically changed from prerelease-1.7.0 to master October 5, 2025 17:32
@debjit-bw debjit-bw changed the base branch from master to prerelease/v1.8.2 October 14, 2025 08:56
@debjit-bw debjit-bw changed the title feat: custom primitives for aura headers feat: support Gnosis primitives (full history 1 of 2) Oct 14, 2025
@debjit-bw debjit-bw marked this pull request as ready for review October 14, 2025 10:54
Copy link
Member

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward change! thanks for the PR notes

pub type BlockBody = alloy_consensus::BlockBody<TransactionSigned, GnosisHeader>;

/// Trait to convert a consensus block into a `GnosisBlock`
pub trait IntoBlock {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name the trait IntoGnosisBlock and the function into_gnosis_block. Is this used widely? Why not just have a helper somewhere instead of the trait?

pub type TransactionSigned = alloy_consensus::EthereumTxEnvelope<TxEip4844>;

pub type GnosisHeader = alloy_consensus::Header;
// pub type GnosisHeader = alloy_consensus::Header;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete comment

Copy link
Member

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge as is, the comments are minor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants