Skip to content

Use upgraded pip in test fixture virtual environment #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Use upgraded pip in test fixture virtual environment #1864

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8ee4f
Start fixing venv test fixture pip toml bug
EliahKagan Mar 11, 2024
a262a06
Upgrade test fixture pip in venv without upgrade_deps
EliahKagan Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/lib/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
import logging
import os
import os.path as osp
import subprocess
import sys
import tempfile
import textwrap
import time
Expand Down Expand Up @@ -411,6 +413,13 @@ def __init__(self, env_dir, *, with_pip):
self._env_dir = env_dir
venv.create(self.env_dir, symlinks=True, with_pip=with_pip)

if with_pip:
# The upgrade_deps parameter to venv.create is 3.9+ only, so do it this way.
command = [self.python, "-m", "pip", "install", "--upgrade", "pip"]
if sys.version_info < (3, 12):
command.append("setuptools")
subprocess.check_output(command)

@property
def env_dir(self):
"""The top-level directory of the environment."""
Expand Down