fix: go back to using root user in Dockerfile #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to do this because we have no active way to change permissions to $GITHUB_OUTPUT to a specific user when running the container Add trivy ignore to top of Dockerfile to pass linting Signed-off-by: jmeridth <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the Dockerfile to use the root user instead of a non-root user to resolve permission issues with accessing $GITHUB_OUTPUT when running the container in GitHub Actions. The change simplifies the container setup by removing user creation and permission management, and adds security scanner ignore directives to pass linting requirements.
Key Changes:
- Removed non-root user creation and configuration
- Added security scanner ignore directives (checkov and trivy)
- Simplified container setup to run as root user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
We have to do this because we have no active way to change permissions to $GITHUB_OUTPUT to a specific user when running the container
Add trivy ignore to top of Dockerfile to pass linting
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenanceorbreaking