Skip to content

Fix using relative URLs in src #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Add note about loadend -> remote-input-success
merged 1 commit into from
Sep 20, 2019
Merged

Fix using relative URLs in src #13

merged 1 commit into from
Sep 20, 2019

Conversation

@muan
Copy link
Contributor

@muan muan commented Sep 18, 2019

On http://localhost/demo/remote-input/, <remote-input src="../test"> fetches http://localhost/test instead of http://localhost/demo/test.

This uses window.location.href to set URL so relative URLs are respected.

@muan muan requested a review from a team September 18, 2019 20:33
dgraham
dgraham approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@muan muan merged commit d903f1f into master Sep 20, 2019
@muan muan deleted the relative-url branch September 23, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@keithamus keithamus keithamus approved these changes

@dgraham dgraham dgraham approved these changes

@koddsson koddsson koddsson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@muan @keithamus @dgraham @koddsson