feat: remove JSX namespace from element definition #335
+103
−96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333
With the changes to React's JSX namespace, this PR updates our
definemodule so that it no longer definesrelative-timeunderJSX.IntrinsicElements. Instead, we include a snippet in the README now that details how to use this alongside React. In the future we could also add a wrapper for this for React.This helps to avoid any future issues with changes to React's typescript types and means we don't have to specify any optional dependencies when using the
declare module 'react'syntax.Curious what you all think about this change 👀 Let me know if there would be a better way here!
In terms of versioning, since this would break existing usage of this element I believe we should treat this as a major change.