Skip to content

Conversation

paxos
Copy link
Contributor

@paxos paxos commented Nov 22, 2021

Stops the stacking of lists when using different list styles.

Before:

before.mov

After:

after.mov

Fixes https://github.com/github/special-projects/issues/598

@paxos paxos marked this pull request as ready for review November 22, 2021 22:15
@paxos paxos requested a review from a team as a code owner November 22, 2021 22:15
@paxos paxos requested review from keithamus and srt32 November 22, 2021 22:15
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change 👍

Can we please add tests for this, to validate the behaviour and avoid regressions.

@paxos
Copy link
Contributor Author

paxos commented Nov 24, 2021

Thank you @keithamus - added more tests.

I am putting this PR back to draft for now. I am planning to propose some more changes next week.

@paxos paxos marked this pull request as draft November 24, 2021 22:40
@paxos
Copy link
Contributor Author

paxos commented Dec 2, 2021

Changes are included in #53

@paxos paxos closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants