Add buffer for observed panic #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octosteve
approved these changes
Jul 9, 2024
octosteve
reviewed
Jul 9, 2024
| @@ -100,6 +100,14 @@ type GitHubOrganization struct { | |||
| } | |||
|
|
|||
| func NewAssignmentList(assignments []Assignment) AssignmentList { | |||
| if len(assignments) == 0 { | |||
| return AssignmentList{ | |||
There was a problem hiding this comment.
My only Nit is I'd like to see these wrapped behind a NewEmptyAssignmentList function. @jalafel But it's fine.
There was a problem hiding this comment.
I initially had done that but it does extend the types across the codebase a bit, so I will save this for a different PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
While trying to debug #69 I was running into a panic in the
NewAssignmentListfunction. This panic was caused by an emptyassignmentsslice being passed to the function. To prevent this panic, I added a check to return an emptyAssignmentListwhen theassignmentsslice is empty. I also added a similar check to theNewAcceptedAssignmentListfunction to prevent a panic when an emptyassignments.What approach did you choose and why?
Since it's expected to be able to return an empty list of AcceptedAssignments or regular Assignments, this is the expected behaviour.