Skip to content

Create re-request-review reusable and use it in appropriate places #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2020
Merged

Create re-request-review reusable and use it in appropriate places #953

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5fe99a9
Create re-request-review reusable and use it in appropriate places
HonkingGoose Oct 31, 2020
23f12cc
Merge branch 'main' into docs/897
HonkingGoose Nov 3, 2020
4053a2c
Apply suggestions from code review
HonkingGoose Nov 3, 2020
5430cb5
move heading and reusable up to line 41
HonkingGoose Nov 3, 2020
ca81af5
Merge branch 'main' into docs/897
felicitymay Nov 3, 2020
cf1312f
Merge branch 'main' into docs/897
felicitymay Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ithub/collaborating-with-issues-and-pull-requests/about-pull-request-reviews.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ You can view all of the reviews a pull request has received in the Conversation

{% data reusables.pull_requests.resolving-conversations %}

### Re-requesting a review

{% data reusables.pull_requests.re-request-review %}

### Required reviews

{% data reusables.pull_requests.required-reviews-for-prs-summary %}
Expand Down
4 changes: 4 additions & 0 deletions ...ng-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ Each person who suggested a change included in the commit will be a co-author of
5. Click **Commit changes.**
![Commit changes button](/assets/images/help/pull_requests/commit-changes-button.png)

### Re-requesting a review

{% data reusables.pull_requests.re-request-review %}

### Opening an issue for an out-of-scope suggestion

If someone suggests changes to your pull request and the changes are out of the pull request's scope, you can open a new issue to track the feedback. For more information, see "[Opening an issue from a comment](/github/managing-your-work-on-github/opening-an-issue-from-a-comment)."
Expand Down
2 changes: 2 additions & 0 deletions data/reusables/pull_requests/re-request-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
You can re-request a review, for example, after you've made substantial changes to your pull request.
To request a fresh review from a reviewer, in the sidebar of the **Conversation** tab, click the {% octicon "sync" aria-label="The sync icon" %} icon.