Skip to content

Conversation

@foosel
Copy link
Contributor

@foosel foosel commented Apr 27, 2021

Why:

As it turns out, the release event will not trigger with prereleased type for pre releases getting published from drafts, only with published. This adds a little note to clarify this behaviour.

Closes #5767

What's being changed:

I've added a small note:

Note: The prereleased type will not trigger for pre releases getting published from draft releases. The published type however will. If you want a workflow to run when stable and pre releases are published, subscribe to published instead of released and prereleased.

Check off the following:

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (eg. a "before and after video")

As it turns out, the release event will not trigger with `prereleased` type for pre releases getting published from drafts, only with `published`.
@welcome
Copy link

welcome bot commented Apr 27, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 27, 2021
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for digging into this and for opening a PR to document your findings! I suggested some small wording changes. If this still sounds good to you, I'll get it merged down.

Thanks!

Co-authored-by: Sarah Edwards <[email protected]>
@foosel
Copy link
Contributor Author

foosel commented Apr 27, 2021

Sounds good to me, I've committed these suggestions!

@skedwards88
Copy link
Contributor

Awesome! I'll get this merged down for you.

@skedwards88 skedwards88 enabled auto-merge (squash) April 27, 2021 17:37
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Apr 27, 2021
@skedwards88 skedwards88 merged commit cfe2e81 into github:main Apr 27, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge This pull request is ready to merge triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow trigger "release" w/ type "prereleased" behaves unexpectedly when publishing from a draft

2 participants