-
Notifications
You must be signed in to change notification settings - Fork 64.5k
Make client_secret optional since it's not always required #32628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apps using the device flow does not have a client secret and can generate new access tokens using the refresh_token grant without this parameter in the request.
Example request:
```python
requests.post(
"https://github.com/login/oauth/access_token",
data={
"client_id": "<YOUR CLIENT ID>",
"refresh_token": refresh_token,
"grant_type": "refresh_token",
},
)
```
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
|
@anderssonjohan Thanks so much for opening a PR! I'll get this triaged for review ✨ |
skedwards88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I made a suggestion that I'll go ahead and incorporate, then we'll get this merged for you.
.../apps/creating-github-apps/authenticating-with-a-github-app/refreshing-user-access-tokens.md
Outdated
Show resolved
Hide resolved
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Apps using the device flow does not have a client secret and can generate new access tokens using the refresh_token grant without this parameter in the request.
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Example request:
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
datadirectory.For content changes, I have completed the self-review checklist.