Skip to content

Conversation

@khitab-incubyte
Copy link
Contributor

Why:

Corrected the link: types of contributions which lead no where.
Replaced it with: https://github.com/github/docs/blob/main/contributing/types-of-contributions.md

Found the correct link here: https://github.com/github/docs/blob/main/CONTRIBUTING.md

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Oct 27, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 27, 2021
@ramyaparimi ramyaparimi added contributing docs Content related to our contributing docs hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! and removed triage Do not begin working on this issue until triaged by the team labels Oct 28, 2021
Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khitab-incubyte
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@ramyaparimi ramyaparimi added ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review labels Oct 28, 2021
@ramyaparimi ramyaparimi enabled auto-merge November 4, 2021 14:30
@ramyaparimi ramyaparimi merged commit c92199e into github:main Nov 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributing docs Content related to our contributing docs hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants