-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Convert .codeqlmanifest.json file to codeql-workspace.yml
#9314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a deliberate design choice, albeit one that we could have documented better.
Most users will want to run codeql pack install to install the model pack from the registry. Users will only want to resolve the local model pack if they are running ML-powered queries with a custom model. Therefore by default we want the model pack to be resolved from the package cache.
Does .codeqlmanifest.json support JSON with comments so we can document this inline?
No, but we probably should convert this file to |
The semantics are the same, except one is json, the other is yaml.
5897977 to
5a1663e
Compare
|
@henrymercer I changed this PR to convert to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, suggest we also update the PR description.
Co-authored-by: Henry Mercer <[email protected]>
.codeqlmanifest.json file to codeql-workspace.yml
Also add an explanation about why
codeql/javascript-experimental-atm-modelisn't in the workspace file.