C#: Fix extraction bug for variable declarations in for condition #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion are declared before they are used.
hvitved
previously approved these changes
Dec 11, 2018
hvitved
approved these changes
Dec 17, 2018
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
…ve-is-safe Note that the %q format directive escapes newlines, and therefore prevents log injection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to change the order in which the components of a
for(...; ...; ...)statement are extracted, because the condition can introduce variables in the formx is Y y. Variable declarations need to be extracted before uses of the variable.