CPP: Fix false positives in UnusedStaticVariables.ql #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
reviewed
Dec 5, 2018
change-notes/1.20/analysis-cpp.md
Outdated
|
|
||
| | **Query** | **Expected impact** | **Change** | | ||
| |----------------------------|------------------------|------------------------------------------------------------------| | ||
| | Unused static variable | Fewer false positive results | Variables with the attribute `unused` are now excluded from the query. | |
There was a problem hiding this comment.
I think we should add query ids here as soon as we add entries. Then @felicity-semmle won't have to do detective work to reconstruct them just before the release.
jbj
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query was recognizing attribute
usedbut not attributeunusedon variables (e.g. in boost, wireshark). Both exist and as far as I can tell have subtly different meanings, but both should be excluded from this query.Also added a test.