C++: Add CWE-789 tag to cpp/uncontrolled-allocation-size. #6041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the "Build/check CSV flow coverage report / build (pull_request)" check failing is relevant to this PR. |
I'm surprised about the |
|
Yes. I saw two results that appeared to go through some kind of |
MathiasVP
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the CWE-789 ("Memory Allocation with Excessive Size Value") tag to
cpp/uncontrolled-allocation-size("Overflow in uncontrolled allocation size") in addition to the existing CWE-190 ("Integer Overflow or Wraparound") tag.I considered increasing the
@precision mediumof the query tohighas well. I think the main issue holding it back is uncertainty about taint sources (such as fromgetenv,argv), an issue we're going to have to address properly at some point. There are also some cases involvingstrlenwhich may not actually be abusable.