JS: sharpen js/clear-text-logging (ODASA-7485)
#520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
self-requested a review
as a 
javascript/ql/src/semmle/javascript/security/dataflow/CleartextLogging.qll
Outdated
Show resolved
Hide resolved
|
Ahem 😊 This is the one line that needs to be changed: b780f82#diff-05bc437cd4f51a47cff43223f844d989L55. The character of |
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Add a new diagnostics file class and use it for errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sharpens
js/clear-text-loggingby not propagating through property reads, except if the read leads directly to a source.As may be seen by the branch name, I first anticipated to implement this with flow labels. But in the end, it seemed simpler and safer to just add a single edge barrier.
The evaluation shows that performance is practically unchanged.