C++: No more flow into ReadSideEffect instructions #4393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
added
the
depends on internal PR
|
This PR should be good to go. The remaining changes are accepted in the internal PR. |
jbj
reviewed
Oct 5, 2020
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
Outdated
Show resolved
Hide resolved
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
Outdated
Show resolved
Hide resolved
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
Outdated
Show resolved
Hide resolved
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
Outdated
Show resolved
Hide resolved
- ArgumentNode is now abstract - PrimaryArgumentNode is now an OperandNode. - ArgumentIndirectionNode is now merged into SideEffectArgumentNode.
jbj
previously approved these changes
Oct 5, 2020
Comment on lines
146
to
145
| | test.cpp:235:11:235:20 | (size_t)... | semmle.label | (size_t)... | | ||
| | test.cpp:237:10:237:19 | (size_t)... | semmle.label | (size_t)... | | ||
| | test.cpp:235:2:235:9 | Arg(0) | semmle.label | Arg(0) | | ||
| | test.cpp:237:2:237:8 | Arg(0) | semmle.label | Arg(0) | |
There was a problem hiding this comment.
These toStrings were not very pretty before, and they're not very pretty now. But at least now we have the ability to override their toString in the future because we've separated the argument from the instruction that produces it.
There was a problem hiding this comment.
I just noticed this as well and pushed a better toString. Originally, I had planned on adding this in a future PR, but I couldn't accept these ugly path explanations we got without a specialized toString.
…ized toString on it
jbj
reviewed
Oct 5, 2020
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
Outdated
Show resolved
Hide resolved
…e.qll Co-authored-by: Jonas Jensen <[email protected]>
jbj
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3123 (comment) pointed out its weird to have flow into
ReadSideEffectInstructionas that instruction has no return value, and that it gives confusing path explanations.Now that we have operands as dataflow nodes we can avoid this rule and wire flow directly from the definition of the memory operand instead of going through the
ReadSideEffectInstruction.CPP-difference shows no performance problems.