C++: Taint flow consistency change for strftime #3569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
May 27, 2020
Comment on lines
+18
to
+20
| * An expression is tainted if it could be influenced by an attacker to have | ||
| * an unusual value. | ||
| * |
There was a problem hiding this comment.
I know @jbj mentioned this the other day as his definition of "taint", but he also said that this changes every week. Do we really want to put this definition in a public qldoc?
There was a problem hiding this comment.
It's only every month, not every week ;-). I've asked on Slack to see if the language teams can agree on a definition.
There was a problem hiding this comment.
I'm keen for us to document a working definition of taint, even if we decide to change it later. It seems better than everyone inventing their own understanding, or trying to infer it backwards from existing behaviour of the models (as I have been).
jbj
previously approved these changes
May 28, 2020
jbj
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't have taint flow to the return value of
strftime(see discussion at the end of #3533).I've also added the definition of taint from that discussion to the models library. We can change it if we later think of a better or clearer definition, but I strongly feel that we need to say something about what taint is.