Skip to content

C++: Specialize hasQualifiedName etc. for Function #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

C++: Specialize hasQualifiedName etc. for Function #3339

wants to merge 1 commit into from

Conversation

jbj
Copy link
Contributor

@jbj jbj commented Apr 23, 2020

Locally I've observed that this speeds up hasTaintFlow. Hopefully it also speeds up many other predicates.

@jbj jbj added the C++ label Apr 23, 2020
@jbj
Copy link
Contributor Author

jbj commented Apr 23, 2020

Started https://jenkins.internal.semmle.com/job/Changes/job/CPP-Differences/1063/

@jbj jbj mentioned this pull request Apr 23, 2020
Merged
@jbj
Copy link
Contributor Author

jbj commented Apr 24, 2020

This had the intended effect on hasTaintFlow_dispred#fff in Chromium, speeding it up from 405s to 1s. But the suite overall didn't get faster on either my local Chromium test or CPP-Differences, so I don't think this PR is worth the risk for 1.24.

@jbj jbj closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jbj