-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Data flow: Support stores into nodes that are not PostUpdateNode
s
#3312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5553cd4
to
31b1044
Compare
31b1044
to
e95cc24
Compare
@MathiasVP @jbj Does this help with our current challenges around partial stores in C++ field flow? |
I haven't looked that much at the details yet, but I guess it would mean that we don't need the target of a store to have a |
For those following along, I think this PR is fairly safe - it merely adds a few starting points for the big-step relation used in the dataflow library, which means that it'll now also start at store-targets that aren't |
Yes, that was certainly the intention. Although, it does also remove starting points, namely those |
Stores are currently restricted to target
PostUpdateNode
s (or any other node inlocalFlowEntry()
, such asOutNode
s). However, for C# we are about to model collection-flow using field-flow, so for examplewill be considered a store from
"taint"
into the created array, which is not aPostUpdateNode
.(This PR will conflict with #3110, which renamesMerge conflict resolved by rebasing onto lateststoreDirect
tostore
.)master
.