Skip to content

1.24 release: finalize change notes for C/C++ #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2020
Merged

1.24 release: finalize change notes for C/C++ #3287

merged 2 commits into from
Apr 20, 2020

Conversation

felicitymay
Copy link
Contributor

This PR aims to finalize the analysis change notes ready for inclusion with LGTM Enterprise.

The first commit reorders rows in one table.
The second commit makes the following text changes:

  • Add a note about the new option for alert suppression comments (as per most other languages).
  • Move the "All CWE queries..." row out of the table into a separate paragraph.
  • Combine multiple changes to single queries into single rows.
  • Reorder the list of queries in another row so they're alphabetic
  • Revise the text describing the new interface for allocation and deallocation.

Please check that you're happy with my changes and that I haven't introduced any errors: @Semmle/cpp-analysis

@felicitymay felicitymay added this to the 1.24 milestone Apr 17, 2020
geoffw0
geoffw0 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@felicitymay felicitymay merged commit 962f13e into github:rc/1.24 Apr 20, 2020
jbj
jbj reviewed Apr 20, 2020
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

felicitymay added a commit that referenced this pull request Apr 20, 2020
@felicitymay
Fix error in 3287
dc83ac6 
@jbj - apologies for the over-eager merge of #3287. This should fix the error you highlighted.
@felicitymay felicitymay mentioned this pull request Apr 20, 2020
Merged
@felicitymay felicitymay deleted the 1.24/SD-61-Cpp-finalize-notes branch April 28, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.
3 participants
@felicitymay @jbj @geoffw0