Skip to content

Conversation

felicitymay
Copy link
Contributor

This PR aims to finalize the analysis change notes ready for inclusion with LGTM Enterprise.

I've made few changes. This set of change notes was already in great order. Thanks πŸ™‡β€β™€οΈ

The first commit reorders rows in one table and the list of frameworks.
The second commit makes a few text changes, mostly to reinforce the reduction in the number of results.

Please check that I haven't introduced any errors: @Semmle/js

@felicitymay felicitymay changed the base branch from master to rc/1.24 April 17, 2020 11:56
@felicitymay felicitymay added this to the 1.24 milestone Apr 17, 2020
Copy link
Contributor

@esbena esbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With one minor style question.

@felicitymay felicitymay merged commit 3bfcd61 into github:rc/1.24 Apr 20, 2020
@felicitymay felicitymay deleted the 1.24/SD-61-JS-finalize-notes branch April 28, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants