-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update some out of date information #3227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍🏼 apart from the table formatting issue (James beat me to it 😉) |
Sorry, I forgot to 👀 the pinned message! |
Thanks both of you |
Co-Authored-By: James Fletcher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(once checks pass)
Co-Authored-By: Shati Patel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this really should be good to merge now 😅
Many thanks for the reviews @shati-patel and @jf205. This probably should wait for the JavaScript and C/C++ teams to check they're happy with the changes to the library text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ changes look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS changes LGTM
c570ebe
I've merged the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved and ready for merging! 👍🏼
This PR updates a few out of date references to Semmle and was prompted by reviewing #3226.
We don't distribute queries and libraries with the new generation of CodeQL tools, so I've also revised a couple of references to this.