Skip to content

Update some out of date information #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2020

Conversation

felicitymay
Copy link
Contributor

This PR updates a few out of date references to Semmle and was prompted by reviewing #3226.

We don't distribute queries and libraries with the new generation of CodeQL tools, so I've also revised a couple of references to this.

@shati-patel
Copy link
Contributor

👍🏼 apart from the table formatting issue (James beat me to it 😉)

@jf205
Copy link
Contributor

jf205 commented Apr 8, 2020

Sorry, I forgot to 👀 the pinned message!

@felicitymay
Copy link
Contributor Author

Thanks both of you

shati-patel
shati-patel previously approved these changes Apr 8, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
(once checks pass)

shati-patel
shati-patel previously approved these changes Apr 8, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this really should be good to merge now 😅

@felicitymay
Copy link
Contributor Author

Many thanks for the reviews @shati-patel and @jf205. This probably should wait for the JavaScript and C/C++ teams to check they're happy with the changes to the library text.

rdmarsh2
rdmarsh2 previously approved these changes Apr 8, 2020
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ changes look good to me

@felicitymay felicitymay added this to the 1.24 milestone Apr 14, 2020
asgerf
asgerf previously approved these changes Apr 14, 2020
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS changes LGTM

@felicitymay felicitymay dismissed stale reviews from asgerf, rdmarsh2, and shati-patel via c570ebe April 14, 2020 13:10
@felicitymay felicitymay requested a review from a team as a code owner April 14, 2020 13:10
@felicitymay felicitymay changed the base branch from master to rc/1.24 April 14, 2020 13:11
@felicitymay
Copy link
Contributor Author

felicitymay commented Apr 14, 2020

I've merged the rc/1.24 branch into my branch and retargeted the pull request. This has, unfortunately, removed all the approving review comment.

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved and ready for merging! 👍🏼

@felicitymay felicitymay removed the request for review from a team April 14, 2020 13:16
@felicitymay felicitymay merged commit bc25050 into github:rc/1.24 Apr 14, 2020
@felicitymay felicitymay deleted the update-references branch April 28, 2020 18:50
This was referenced May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants