C++: Fix cpp/new-free-mismatch false positives
#3206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The QLDoc check is failing because this is exposing the I think moving the matching into the models is a good idea, but I might have the model make the decision about specific functions or expressions rather than using strings. In any case, we should probably talk about it in an issue rather than a PR. |
|
I've added QLDoc to the top of those files. It's fairly minimal, but points users to the files in |
|
qlformat failed :-/ |
rdmarsh2
previously approved these changes
Apr 7, 2020
|
Sorry about that. Should pass this time... |
jbj
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were four new false positives for
cpp/new-free-mismatching/abseil/abseil-cpp. The issue was that calls toallocator newwere being misrecognized asmalloc-style allocations because they were function calls.I've added test cases and tidied some things up as I went along, including deprecating another part of the legacy wrapper
alloc.qll(something I've been meaning to get around to).I'm thinking about the next step being wrapping the concept of an allocation
kind("malloc","new","new[]") into the models themselves so that we can simplify this and similar code. Perhaps we should also create additionalkinds for some of the more exotic allocators, so that we can detect more kinds of mismatches.