C++: Model taint flow through std::string constructor and c_str() #3195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj
reviewed
Apr 3, 2020
| /** | ||
| * The `std::basic_string` constructor(s). | ||
| */ | ||
| class StringConstructor extends TaintFunction { |
There was a problem hiding this comment.
Since the term "string" means so many different things in C/C++, I'd prefer more precise names for this file and its classes: StdString.qll, StdStringConstructor, StdStringCStr.
jbj
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very incomplete model of
std::string, based on #1637 but a less ambitious starting point. I have put in the tests foroperator<<as well but it's not yet modeled.