docs: expand QL book entry on monotonic aggregates #2837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexet over to you for a technical review please |
alexet
reviewed
Feb 17, 2020
| value for each value generated by the ``<formula>``: | ||
|
|
||
| - If there are missing ``<expression>`` values (that is, there is less than one | ||
| ``<expression>`` value for each value generated by the ``<formula>``), monotonic aggregates |
There was a problem hiding this comment.
I think this should be something like "for a value generated by the <formula>" otherwise it reads to me like every value must be missing in this case.
"there is less than one <expression>" might be simpler as "there is no <expression>" as the numbers here are natural numbers.
alexet
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2829 (and partially fixes https://github.com/github/product-documentation/issues/2188).
I've moved Monotonic aggregates in QL into the QL language handbook, so that we can remove the 'Advanced QL' section altogether before we move any of the CodeQL docs.
@alexet: I've tried to simplify the content into couple of bullet points, but I've left in the full example for the recursive use. Please can you review the changes?
After this is merged I'll open a separate PR to do the final bits of tidying up of Advanced QL.