Skip to content

Fix a few typos in the QL grammar #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2020
Merged

Fix a few typos in the QL grammar #2791

merged 2 commits into from
Feb 10, 2020

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Feb 7, 2020

Typos:

  • atlowerId -> atLowerId
  • :: = -> ::=

There is also a trailing ; in the start symbol definition (ql). I don't know what it is supposed to mean. Should it be removed?

@aibaars aibaars requested a review from p0 February 7, 2020 11:51
@jf205
Copy link
Contributor

jf205 commented Feb 10, 2020

Thanks @aibaars. Over to @p0 to review and merge this change.

@p0 p0 merged commit 09960e0 into github:master Feb 10, 2020
@jf205 jf205 mentioned this pull request Feb 11, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Jun 23, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 13, 2022
Open
@aliscco aliscco mentioned this pull request Sep 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jf205 jf205 Awaiting requested review from jf205

@shati-patel shati-patel Awaiting requested review from shati-patel

1 more reviewer

@p0 p0 p0 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aibaars @jf205 @p0