Learning CodeQL docs: add COBOL notes and remove links #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicitymay
reviewed
Dec 3, 2019
There was a problem hiding this comment.
Thanks for these updates. Generally they look good.
https://jenkins.internal.semmle.com/job/Docs/job/Generate-Sphinx/1125/artifact/target/sphinx/learn-ql/cobol/introduce-libraries-cobol.html has a link to LGTM help about the query console which should probably be omitted too.
felicitymay
approved these changes
Dec 3, 2019
|
This was merged into master, but it should have been rc/1.23 (my fault). I'll revert and open a new PR against the correct branch. |
This was referenced Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notes (in the form of a snippet) about the future of COBOL support to 'CodeQL for COBOL' in the 'Learning CodeQL' project and in a couple of places in the 'Support' project. The two links to the soon-to-be-removed LGTM URLs have also been deleted.
@felicitymay, do you think these notes appear in the correct places?
I've also bumped the version number for the projects that use
global-conf/pyand the 'CodeQL training' project.