Skip to content

1.23 SD4095 finalize change notes for Csharp #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

felicitymay
Copy link
Contributor

@Semmle/cs - I've made some small changes to the text in the first commit. The second commit just fixes the sort order in the first table.

The last query "Unsafe deserializer (cs/unsafe-deserialization)" doesn't appear to be on LGTM.com yet. Is this expected?

@calumgrant
Copy link
Contributor

The query cs/unsafe-deserialization currently has a low precision so will not be shown.

Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just that comment on cs/unsafe-deserialization

@felicitymay
Copy link
Contributor Author

@calumgrant - are there any changes you'd like me to make, or is this ready to merge?

@calumgrant calumgrant changed the title 1.23: SD-4095 finalize change notes for C# 1.23 SD4095 finalize change notes for Csharp Dec 3, 2019
@felicitymay
Copy link
Contributor Author

There appear to be problems caused by my choice of branch name. Closing in favor of #2490

@felicitymay felicitymay closed this Dec 3, 2019
@felicitymay felicitymay deleted the 1.23/SD-4095-finalize-change-notes-c# branch March 13, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants