JS: fix the check for an "mjs" extension on an extensionless file #2347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-schaefer
approved these changes
Nov 15, 2019
|
That merge was a bit early. We are still waiting for the eval...
…On Fri, Nov 15, 2019, 17:39 Erik Krogh Kristensen ***@***.***> wrote:
Merged #2347 <#2347> into rc/1.23.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2347>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOV7AJ23OUX72DCRVHVHUDQT3GDDANCNFSM4JN3TZTA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix allows us to resolve
require-imports in files without extensions.The fix enables us to flag: CVE-2018-16479.
An evaluation is on the way.
It is (apparently) tricky to make qltest test the fix, but it has been confirmed locally with
codeql ...invocations that this fix works.I am opening this PR now to get it into the 1.23 workflow.