Skip to content

Add qlpack.yml files for test folders. #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Add qlpack.yml files for test folders. #2302

merged 1 commit into from
Nov 13, 2019

Conversation

max-schaefer
Copy link
Contributor

As discussed on Slack, this allows the extension to correctly compile .ql and .qll files in these folders.

@max-schaefer max-schaefer requested review from a team as code owners November 12, 2019 15:05
hvitved
hvitved previously approved these changes Nov 12, 2019
View reviewed changes
@hmakholm
Copy link
Contributor

Since we're almost at Universe, let's bump the version numbers to 1.0.0 for each of these from the get-go. (I'm just about to create a PR that does this for the existing qlpack.yml).

@hmakholm
Copy link
Contributor

Otherwise LGTM.

@max-schaefer
Copy link
Contributor Author

@hmakholm, done.

hmakholm
hmakholm previously approved these changes Nov 12, 2019
View reviewed changes
@hmakholm hmakholm mentioned this pull request Nov 12, 2019
Closed
@max-schaefer
Copy link
Contributor Author

Switched version numbers back to 0.0.0 as per discussion here.

@dbartol
Copy link

dbartol commented Nov 12, 2019

Did we ever agree on a way to specify where to find test directories in a qlpack? If so, we might as well mark the test directories in these packs (just ., I presume).

@hmakholm
Copy link
Contributor

No, there is no current mechanism for that -- at the time it seemed futile, because preserving the opportunity to run "all queries in this pack" meant that tests would need to be separate packs in the common case after all.

@dbartol
Copy link

dbartol commented Nov 12, 2019

OK, we'll just figure out how it should work as we bring codeql test support up, I guess.

dbartol
dbartol approved these changes Nov 13, 2019
View reviewed changes
Copy link

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbartol dbartol merged commit e89ecc1 into github:master Nov 13, 2019
@max-schaefer max-schaefer deleted the test-qlpacks branch November 18, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved left review comments

@hmakholm hmakholm hmakholm left review comments

+1 more reviewer

@dbartol dbartol dbartol approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-schaefer @hmakholm @dbartol @hvitved