Skip to content

Conversation

asger-semmle
Copy link
Contributor

The extractor would crash if given the following invalid TypeScript file:

export class {}

We bail out if the TypeScript compiler reports a syntax error, but in this case, it's not reported as a syntax error, but presumably some other kind of error in a later pass we don't run as part of extraction.

The anonymous class was somewhat optimistically converted to a ClassExpression which led to a crash, as the top-level is expected to contain statements, not expressions.

@asger-semmle asger-semmle requested a review from a team as a code owner October 23, 2019 10:56
@semmle-qlci semmle-qlci merged commit fc8c1e1 into github:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants