TS: Tolerate syntax errors in class declaration #2177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extractor would crash if given the following invalid TypeScript file:
We bail out if the TypeScript compiler reports a syntax error, but in this case, it's not reported as a syntax error, but presumably some other kind of error in a later pass we don't run as part of extraction.
The anonymous class was somewhat optimistically converted to a
ClassExpression
which led to a crash, as the top-level is expected to contain statements, not expressions.