Skip to content

C++: Add models for strlcpy and strlcat #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 10, 2023
Merged

C++: Add models for strlcpy and strlcat #14735

merged 7 commits into from
Nov 10, 2023

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Nov 9, 2023

No description provided.

@jketema jketema requested a review from a team as a code owner November 9, 2023 16:22
@github-actions github-actions bot added the C++ label Nov 9, 2023
MathiasVP
MathiasVP reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but otherwise this LGTM (assuming DCA comes back clean!)

MathiasVP
MathiasVP previously approved these changes Nov 9, 2023
View reviewed changes
@jketema
Copy link
Contributor Author

jketema commented Nov 9, 2023 •
edited
Loading

Looking at the DCA results, all new cpp/bad-strncpy-size results look like FPs, so I think strlcat needs to be its own separate model. Its size argument behaves different from strncat. The new cpp/bad-strncpy-size results look TPs, and the behaviour of its size argument is also similar to that of strncpy.

MathiasVP
MathiasVP reviewed Nov 10, 2023
View reviewed changes
geoffw0
geoffw0 reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picking...

MathiasVP
MathiasVP previously approved these changes Nov 10, 2023
View reviewed changes
@jketema
Copy link
Contributor Author

jketema commented Nov 10, 2023

Note that I'm rerunning DCA at the moment just to be sure the latest changes don't break things.

@jketema
Copy link
Contributor Author

jketema commented Nov 10, 2023

DCA looks good to me. The alert changes still look correct.

Does this need a change note?

@MathiasVP
Copy link
Contributor

Good point. Yeah, I think we should add a change note 👍

@jketema
Copy link
Contributor Author

jketema commented Nov 10, 2023

Done. Will need re-approval - assuming the change note is ok.

MathiasVP
MathiasVP approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jketema jketema merged commit 3a62628 into github:main Nov 10, 2023
@jketema jketema deleted the strl branch November 10, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffw0 geoffw0 geoffw0 left review comments

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++ documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jketema @MathiasVP @geoffw0