Skip to content

C++: AssignPointerAddExpr and AssignPointerSubExpr should not be bitwise operations #14635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2023
Merged

C++: AssignPointerAddExpr and AssignPointerSubExpr should not be bitwise operations #14635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86fe5b4
C++: Remove 'assignpaddexpr' and 'assignpsubexpr' from the 'assign_bi…
MathiasVP Oct 30, 2023
efe0642
C++: Add up and downgrade scripts.
MathiasVP Oct 30, 2023
6e385ca
C++: Add change note.
MathiasVP Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,231 changes: 2,231 additions & 0 deletions cpp/downgrades/8cba93a44180e0d50a80a660950800d822b981fc/old.dbscheme
View file
Open in desktop

Large diffs are not rendered by default.

2,226 changes: 2,226 additions & 0 deletions cpp/downgrades/8cba93a44180e0d50a80a660950800d822b981fc/semmlecode.cpp.dbscheme
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions cpp/downgrades/8cba93a44180e0d50a80a660950800d822b981fc/upgrade.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
description: Removed @assignpaddexpr and @assignpsubexpr from @assign_bitwise_expr
compatibility: full
4 changes: 4 additions & 0 deletions cpp/ql/lib/change-notes/2023-10-31-assign-pointer-add-sub-expr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: breaking
---
* The expressions `AssignPointerAddExpr` and `AssignPointerSubExpr` are no longer subtypes of `AssignBitwiseOperation`.
9 changes: 7 additions & 2 deletions cpp/ql/lib/semmlecode.cpp.dbscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,11 +1334,16 @@ funbind(
| @assignxorexpr
| @assignlshiftexpr
| @assignrshiftexpr
| @assignpaddexpr
;

@assign_pointer_expr = @assignpaddexpr
| @assignpsubexpr
;

@assign_op_expr = @assign_arith_expr | @assign_bitwise_expr
@assign_op_expr = @assign_arith_expr
| @assign_bitwise_expr
| @assign_pointer_expr
;

@assign_expr = @assignexpr | @assign_op_expr | @blockassignexpr

Expand Down
Loading