JS: Move Directive subclasses into module and support "use client/server" #13303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
force-pushed
the
js/use-server-and-client
branch
from
9b1f133 to
a0e60e6
Compare
asgerf
force-pushed
the
js/use-server-and-client
branch
from
a0e60e6 to
7a79608
Compare
asgerf
force-pushed
the
js/use-server-and-client
branch
from
7a79608 to
f8641dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13296
The subclasses of
KnownDirectivewere all declared at the top-level ofStmt.qll. This means we couldn't add new subclasses without introducing a top-level name exported byjavascript.qll. So this PR first moves all those subclasses into aDirectivesmodule. Thanks to the new shadowing rules we can actually leave deprecated aliases for these in the top-level.Lastly this adds two more directives to handle
"use client"and"use server".