-
Notifications
You must be signed in to change notification settings - Fork 376
Validate the codeql-action workspace for common errors #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Definitely a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but generally looks good and pretty clean and effective for notifying people of changes to how the workflow should look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine now and all LGTM
This PR will automatically debug common issues with CodeQL workspaces:
run: git checkout HEAD^2
Todo:
In an ideal world, I would love if I could get the actions scheduler to pass in the current workflow file as GITHUB_WORKFLOW_FILE. This would make introspection easier, running the action locally easier and save two API requestsI explored this idea and opened a feature request here: actions/runner#825