Only warn about path filters in the Action if the CLI doesn't already warn #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelapwen
approved these changes
Feb 27, 2024
Contributor
angelapwen
left a comment
angelapwen
left a comment
There was a problem hiding this comment.
Makes sense to me, and agree that the double-warning for folks on older versions isn't too big of a deal 😄
8 tasks
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving the notice when a language does not support path filtering into the CLI so that it's available for all customers including those using third-party CI systems. Therefore, to avoid duplicate warnings, this PR updates the Action such that it only warns for older CLIs that don't support this feature.
This does mean that customers on older versions of the Action using newer CLIs might see the warning twice in the logs. I don't think this is enough of a problem to be worth addressing.
Merge / deployment checklist