-
Notifications
You must be signed in to change notification settings - Fork 686
feat: support multiple SSM parameters for large runner matcher configs (#4790) #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple SSM parameters for large runner matcher configs (#4790) #4792
Conversation
npalm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edersonbrilhante nice contribution. I just tried the parameter split with the multi-runner example in this repo. By adding a few config and adding more labes. Result is I got this error, related to the added foreach
│
│ on ../../modules/webhook/webhook.tf line 27, in resource "aws_ssm_parameter" "runner_matcher_config":
│ 27: for_each = { for idx, val in local.matcher_chunks : idx => val }
│ ├────────────────
│ │ local.matcher_chunks will be known only after apply
│
│ The "for_each" map includes keys derived from resource attributes that cannot be determined until apply, and so Terraform cannot determine the full set of keys that will
│ identify the instances of this resource.
│
│ When working with unknown values in for_each, it's better to define the map keys statically in your configuration and place apply-time results only in the map values.
│
│ Alternatively, you could use the -target planning option to first apply only the resources that the for_each value depends on, and then apply a second time to fully
│ converge.
Wondering you you tested the change? I was not able to get it working right now.
|
I did test it, but I forgot to include a large configuration and only tested the normal case. My bad. I found the same bug now. |
|
@npalm I just pushed my fix. I tested a normal config and a tested a really big one with 7 ssm resources and it worked fine now. |
|
Thx for the updates, will not be able to able to get the PR merged in the next weeks. I will catch up end of the month. Sorry for tthe delay. |
|
No problem. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Implements support for splitting the runner matcher configuration across multiple SSM parameters to avoid size limits for large configurations. The primary change allows PARAMETER_RUNNER_MATCHER_CONFIG_PATH to accept multiple parameter paths separated by a colon.
- Added logic to split large runner matcher configurations into chunks based on SSM parameter tier limits
- Updated infrastructure to create multiple SSM parameters when needed and pass them as a list
- Modified configuration loader to handle multiple parameter paths and combine them at runtime
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/webhook/webhook.tf | Implements chunking logic and creates multiple SSM parameters for large configs |
| modules/webhook/eventbridge/webhook.tf | Updates environment variable to join multiple parameter paths with colons |
| modules/webhook/eventbridge/variables.tf | Changes ssm_parameter_runner_matcher_config from object to list of objects |
| modules/webhook/eventbridge/dispatcher.tf | Updates IAM policy and environment variables to handle multiple parameters |
| modules/webhook/direct/webhook.tf | Updates environment variables to join multiple parameter paths with colons |
| modules/webhook/direct/variables.tf | Changes ssm_parameter_runner_matcher_config from object to list of objects |
| lambdas/functions/webhook/src/ConfigLoader.ts | Implements logic to load and combine configuration from multiple SSM parameters |
| lambdas/functions/webhook/src/ConfigLoader.test.ts | Adds test coverage for multi-parameter configuration loading |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
npalm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edersonbrilhante took a while but tested and reviewed the PR.
- I left some small comments, one permission needs to be dropped
- can you have a look on the copilot suggestions as well
- I have tested incrasing the matching resulting in a split. and down size back to a single matcher variable. All works like a hcarm.
trigger ci with a minor change
35d3f6d to
d751541
Compare
f8ef0cc to
efc0ee2
Compare
c6a2f6d to
5c6bf59
Compare
b4d3e23 to
3098478
Compare
|
Expect to have time later this week to re-review the PR. Thanks for the updates |
stuartp44
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small feedback from me
change requested on generated files.
🤖 I have created a release *beep* *boop* --- ## [6.9.0](v6.8.5...v6.9.0) (2025-11-13) ### Features * support multiple SSM parameters for large runner matcher configs ([#4790](#4790)) ([#4792](#4792)) ([4d4872f](4d4872f)) @edersonbrilhante ### Bug Fixes * **lambda:** bump @octokit/rest from 22.0.0 to 22.0.1 in /lambdas in the octokit group ([#4876](#4876)) ([807aeef](807aeef)) * **lambda:** bump the aws group across 1 directory with 7 updates ([#4871](#4871)) ([8737fe2](8737fe2)) * **lambda:** bump the aws-powertools group in /lambdas with 4 updates ([#4865](#4865)) ([8c76e12](8c76e12)) * **lambda:** bump the octokit group across 1 directory with 4 updates ([#4873](#4873)) ([39fc3cf](39fc3cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
PR Description
Implements support for splitting the runner matcher configuration across multiple SSM parameters.
PARAMETER_RUNNER_MATCHER_CONFIG_PATHcan now accept multiple parameter paths separated by a colon (:).This avoids SSM size limits for large configurations and improves scalability for environments with many runner types and labels.
Closes #4790