gateway external peerings #972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edipascale
force-pushed
the
ema/externals-as-vpc
branch
4 times, most recently
from
886e0fb to
97f2f1d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for gateway external peerings to complement existing switch external peerings. The changes enable users to configure external connectivity through gateways in addition to the existing switch-based approach.
- Adds gateway mode support for external peerings with new
gw/gatewayoption - Implements gateway peering logic that creates
PeeringSpecentries for VPC-to-external connectivity - Updates connectivity testing to check both switch and gateway external reachability
Comments suppressed due to low confidence (1)
pkg/hhfab/testing.go:1
- The condition
len(prefixParts) > 1should belen(prefixParts) != 2since splitting by underscore should result in exactly 2 parts for a valid prefix with underscore. The current condition will incorrectly reject valid prefixes.
// Copyright 2024 Hedgehog
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
edipascale
force-pushed
the
ema/externals-as-vpc
branch
2 times, most recently
from
bd1e0c4 to
b5a6473
Compare
edipascale
force-pushed
the
ema/externals-as-vpc
branch
2 times, most recently
from
99460f2 to
ff0f1ed
Compare
edipascale
force-pushed
the
ema/externals-as-vpc
branch
from
ff0f1ed to
901c072
Compare
edipascale
force-pushed
the
ema/externals-as-vpc
branch
from
901c072 to
7af5208
Compare
edipascale
force-pushed
the
ema/externals-as-vpc
branch
from
7af5208 to
cb09227
Compare
Frostman
requested changes
Nov 3, 2025
pkg/hhfab/testing.go
Outdated
| vpc: { | ||
| Expose: []gwapi.PeeringEntryExpose{vpcExpose}, | ||
| }, | ||
| ext: { |
There was a problem hiding this comment.
I think it should have a ext. prefix
There was a problem hiding this comment.
I should have probably tested this again after the changes in the fabric PR 😅 it works fine now. although I don't really like that the user has to create a peering with an ext. prefix to the external name, this will create confusion imho
edipascale
force-pushed
the
ema/externals-as-vpc
branch
from
cb09227 to
d252995
Compare
Signed-off-by: Emanuele Di Pascale <[email protected]>
Signed-off-by: Emanuele Di Pascale <[email protected]>
edipascale
force-pushed
the
ema/externals-as-vpc
branch
from
d252995 to
8d54cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go with githedgehog/fabric#1033