-
-
Notifications
You must be signed in to change notification settings - Fork 7
[work in progress] updating to django 3.1+ #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sethwoodworth
wants to merge
12
commits into
master
Choose a base branch
from
port-py39
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ac1a57a
work in progress updating to django 3.1+
sethwoodworth 7a6c3e3
remove requirements.txt file in favor of Pipenv
sethwoodworth 88da6e8
add ipython and ipdb dev requirements to Pipenv
sethwoodworth ca3035b
move foundation_base.html inside project, update refs, use fontawesom…
sethwoodworth 9ad316b
Update footer social media icons with new font-awesome prefixes for b…
sethwoodworth 7f548d8
Update DEBUG mode static route setup
sethwoodworth 6625e97
Nest many prod settings under if not debug flag
sethwoodworth 2e80379
Update gitberg to >=0.7.4
sethwoodworth ec1fe54
remove readme question
sethwoodworth 148d446
revert readme changes
sethwoodworth aa6437c
Update some README installation and use instructions
sethwoodworth c100fea
add a pin for the local development python version
sethwoodworth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
3.6.7 | ||
3.9.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
{% load static %} | ||
<!doctype html> | ||
<html class="no-js" lang="en"> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
{% block meta %}{% endblock meta %} | ||
{% block base_title %} | ||
<title>{% block title %}Foundation 5.5.0{% endblock title %}</title> | ||
{% endblock base_title %} | ||
|
||
{# Base Foundation CSS #} | ||
{% block foundation_css %} | ||
<link href="{% static "foundation/css/normalize.css" %}" rel="stylesheet"/> | ||
<link href="{% static "foundation/css/foundation.min.css" %}" rel="stylesheet"/> | ||
{% endblock foundation_css %} | ||
|
||
{# Custom CSS #} | ||
{% block css %}{% endblock css %} | ||
|
||
{# Override if you need another version of modernizr #} | ||
{% block foundation_modernizer %} | ||
<script src="{% static "foundation/js/vendor/modernizr.js" %}"></script> | ||
{% endblock foundation_modernizer %} | ||
|
||
{# Custom head JS #} | ||
{% block head_js %}{% endblock head_js %} | ||
</head> | ||
<body {% block body_attr %}{% endblock body_attr %}> | ||
{# Main content goes here #} | ||
{% block base_body %}{% endblock base_body %} | ||
|
||
{# Override if you need another version of jQuery #} | ||
{% block foundation_jquery %} | ||
<script src="{% static "foundation/js/vendor/jquery.js" %}"></script> | ||
{% endblock foundation_jquery %} | ||
|
||
{# Foundation JS #} | ||
{% block foundation_js %} | ||
<script src="{% static "foundation/js/foundation.min.js" %}"></script> | ||
{% endblock foundation_js %} | ||
|
||
{# Custom JS #} | ||
{% block body_js %}{% endblock body_js %} | ||
|
||
{# Init Foundation #} | ||
{% block foundation_js_init %} | ||
<script> | ||
$(document).foundation(); | ||
</script> | ||
{% endblock foundation_js_init %} | ||
</body> | ||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ebcli uses some config magic that's not clear to me, but the install platform default is py3.7 - look in .elasticbeanstalk/config.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anything 3.6+ will let me use f-strings, so that should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the elastic beanstalk config, the base image we're using is python3.6

So I'll revert this back to 3.6 and make sure the site works with 3.6-3.9