bugfix: handle holeSize=0 for doughnut chart #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doughnut chart ignores holeSize=0 as a falsy value and takes is default of 50. Code now checks the type of holeSize to treat 0 as a number and display doughnuts with no hole at all. This leads to a chart very similar to a pie chart, but means that we do not have to change chart type for the 0 special case.
gitbrent
approved these changes
Jan 23, 2023
Owner
|
Thanks @mathbruyen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doughnut chart ignores holeSize=0 as a falsy value and takes is default of 50.
Code now checks the type of holeSize to treat 0 as a number and display doughnuts with no hole at all.
This leads to a chart very similar to a pie chart, but means that we do not have to change chart type for the 0 special case.